Implement ACP-118 Aggregator #3394
Open
+918
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
force-pushed
the
p2p-sync
branch
from
2e59a5d to
e7648e5
Compare
joshua-kim
force-pushed
the
acp-118
branch
6 times, most recently
from
368ad1a to
2a47036
Compare
joshua-kim
force-pushed
the
p2p-sync
branch
from
19d8f83 to
3af3bc9
Compare
joshua-kim
force-pushed
the
acp-118
branch
2 times, most recently
from
6e6e88f to
cf4ecba
Compare
joshua-kim
force-pushed
the
acp-118
branch
2 times, most recently
from
b4d7b35 to
60761f8
Compare
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
aaronbuchwald
approved these changes
Dec 6, 2024
cam-schultz
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
LGTM. This seems like it would really simplify the p2p integration in signature-aggregator. by leveraging the existing p2p.Client. We re-implement a lot of the response handling and routing logic.
| return nil, nil, nil, false, err | ||
| } | ||
|
|
||
| return msg, aggregatedStakeWeight, totalStakeWeight, false, nil |
There was a problem hiding this comment.
[no action required] It looks like this is the only case that returns a non-nil message with finished=false. Could we simplify the function signature by removing that parameter and assuming the caller is aware of a cancelled context?
iansuvak
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Implements
p2pclient + server logic for signature request handling as described inacp-118(ref).How this works
Client:
How this was tested